[Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

[Rob Landley]

On 10/26/21 9:05 AM, Eric Molitor wrote:
> Attached is an initial cleanup of wget. This addresses a number of defects with
> the existing implementation and generally cleans up the code. I've squashed the
> commits but can provide a more incremental set of patches if desired. I have two
> more pending changes which correctly add HTTP 1.1 support, including support for
> chunked encoding, as well as adding TLS support. However this was already a huge
> change so working on landing this first before submitting the others changes.

Applied, but I'm not sure this moves it _closer_ to getting out of pending:

+#define WGET_FILENAME "Content-Disposition: attachment; filename="
...
+  f = wget_strncaseafter(toybuf, WGET_FILENAME, body - toybuf);

What does splitting a string a hundred lines away from its only user accomplish?

Rob