[Toybox] [PATCH] xfork: fix #if.

Rob Landley rob at landley.net
Wed Oct 27 22:33:57 PDT 2021


On 10/27/21 11:14 AM, enh via Toybox wrote:
> Fixes 298 where `make allyesconfig` failed with an undefined reference
> to xfork().

The CFG_XXX macros are always #defined, to either 0 or 1. So #if is correct.
What you just did was disable the test.

What's happening here is allyesconfig is enabling TOYBOX_FORCE_NOMMU which is
removing xfork() which is causing commands that use xfork() without having a
"depends on TOYBOX_FORK" to fail. Which means some commands need "depends on
TOYBOX_FORK" added so allyesconfig won't try to build them, since allyesconfig
forces toybox into nommu support mode and thus disables fork().

I'd try to fix it if you'd mentioned _what_ failed, but you didn't. I'd check
myself, but I'd have to set up a system it builds in...

toys/lsb/md5sum.c:76:10: fatal error: openssl/md5.h: No such file or directory
 #include <openssl/md5.h>

(I have previously mentioned that allyesconfig is conceptually problematic,
right? Meanwhile, over in the linux kernel, "allnocofig" disables the "embedded"
menu meaning you have to switch ON certain symbols in order to be able to switch
stuff OFF...)

Rob



More information about the Toybox mailing list