[Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

[Eric Molitor]

Ok this annoyed me so I just added direct OpenSSL support parallel to the
LibTLS support. Elliot, the OpenSSL version should work with the latest
versions of BoringSSL that Android is using.

- Eric

On Thu, Oct 28, 2021 at 1:19 PM Eric Molitor <emolitor at molitor.org> wrote:

> Annoyingly libretls requires openssl 1.1.1b or higher which means
> BoringSSL (1.1.0) is missing the newer IO socket abstractions which
> libretls is depending upon. Do you know if there are plans to upgrade the
> interfaces of BoringSSL to support the new API? I was hoping to avoid
> directly holding the OpenSSL API's.
>
> - Eric
>
> On Thu, Oct 28, 2021 at 10:59 AM Eric Molitor <emolitor at molitor.org>
> wrote:
>
>> Reworked TLS patch. This limits the make.sh change to just tls which
>> should resolve any concerns about multiple libraries. This also folds in a
>> few fixes I've found while testing. Elliot this should work with
>> LibreTLS+BoringSSL but I've not had a chance to test that yet.
>>
>> - Eric
>>
>> On Thu, Oct 28, 2021 at 8:17 AM Eric Molitor <emolitor at molitor.org>
>> wrote:
>>
>>> Let me clean this up first and do a bit more testing to sort the
>>> libraries out. Yeah BoringSSL uses the same symbols as older OpenSSL. If
>>> you do want to give it a whirl there is a new experimental WGET_TLS
>>> suboption to enable in addition to WGET. For BoringSSL you also need to
>>> have LibreTLS to link against.
>>>
>>> - Eric
>>>
>>>
>>> On Thu, 28 Oct 2021, 7:06 am enh, <enh at google.com> wrote:
>>>
>>>> Iirc boringssl uses the same library names as openssl. If you want me
>>>> to try something tomorrow, let me know what. Just change wget to =y in
>>>> .config and see what libraries I need to add for it to link?
>>>>
>>>> On Wed, Oct 27, 2021, 22:50 Rob Landley <rob at landley.net> wrote:
>>>>
>>>>> On 10/27/21 11:58 AM, Eric Molitor wrote:
>>>>> > Final patch which adds TLS support.
>>>>> >
>>>>> > - Eric
>>>>>
>>>>> Hmmm, the lib stuff is awkward. (If you have more than one installed,
>>>>> I think it
>>>>> will try to link to both. Which seems unlikely to work? And I dunno
>>>>> what android
>>>>> calls boringssl. It would be nice if there was a standard alias name
>>>>> symlink,
>>>>> but alas...)
>>>>>
>>>>> And the changes to scripts/make.sh are _not_ in pending. Hmmm...
>>>>>
>>>>> Rob
>>>>> _______________________________________________
>>>>> Toybox mailing list
>>>>> Toybox at lists.landley.net
>>>>> http://lists.landley.net/listinfo.cgi/toybox-landley.net
>>>>>
>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20211028/46a662bc/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-wget-Add-OpenSSL-Support.patch
Type: application/octet-stream
Size: 4054 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20211028/46a662bc/attachment-0006.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-wget-Add-LibTLS-Support-v3.patch
Type: application/octet-stream
Size: 8518 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20211028/46a662bc/attachment-0007.obj>