[Toybox] [PATCH] tar: fix warn_unused_result error.

[Rob Landley]

On 9/2/21 2:58 PM, enh wrote:
>     That's why android-ndk-r21d isn't producing this warning. 
> 
> yeah, sorry: this is for the _host_ toybox (so glibc right now).

It's not doing it in my host build. Do I have to #define FORTIFY_STUFF somewhere...

# if __USE_FORTIFY_LEVEL > 0
#  define __wur __attribute_warn_unused_result__
# endif
#else
# define __attribute_warn_unused_result__ /* empty */
#endif

Apparently so. Sigh.

> adding more of these to bionic has been on the to-do list for years, but turning
> up warnings is always a  hard slog... (see my comment about updating the
> compiler in my previous response!)

I'm happy for it NOT to produce this warning, I'm just trying to reproduce the
one you wanted to eliminate. :)

>     Would upgrading to a
>     newer version get it, 
> 
> not until i add more annotations to bionic, no :-)
>  
>     or is this more aosp-vs-ndk version skew? (And is there an
>     easy way to build external packages with the AOSP prebuilt toolchain?)
> 
> if you actually find yourself in a situation where bionic has something that
> isn't in the NDK yet, it's probably easier to update the sysroot (which only
> requires an NDK manifest checkout, not a full AOSP manifest checkout):
> 
> https://android.googlesource.com/platform/ndk/+/master/docs/PlatformApis.md#updating-the-sysroot
> <https://android.googlesource.com/platform/ndk/+/master/docs/PlatformApis.md#updating-the-sysroot>

Someday I would like to figure out how to build the NDK from source, but I have
zero spare bandwidth at the moment...

Rob