[Toybox] [PATCH] Fix xsignal_all_killers().

Rob Landley rob at landley.net
Wed Sep 1 09:34:02 PDT 2021


On 8/30/21 4:00 PM, enh wrote:
>     Your commit changed list_signals() to start from 1 but didn't do the same for
>     xsignal_all_killers(). One character fix. 
> 
> yeah, i sent you a more complicated fix in case someone was tempted to reorder
> the array (note that in list_signals() the loop variable is the signal number,
> but in xsignal_all_killers() the loop variable is the array index), but (a) your
> smaller fix works and (b) we know we have a test that will catch this if someone
> does break it, so lgtm :-)

It would break list_signals() if they reordered the list, so I didn't add a new
dependency. :)

> thanks! (and sorry for not running all the tests! it's _just_ slow enough on my
> laptop to run them all that i tend to only run the specific toy's tests.)

Eh, I should have done it here myself. (Touching an individual command file
doesn't break other commands, but touching lib/ or main.c does.)

Rob



More information about the Toybox mailing list