[Toybox] [PATCH] rmmod: various fixes.

Rob Landley rob at landley.net
Sat Sep 11 10:21:33 PDT 2021


On 9/10/21 6:10 PM, enh via Toybox wrote:
> My original intent was to just get rid of the meaningless O_EXCL, which
> isn't used by the kernel, after noticing that it's passed here but not
> in modprobe's module removal code.
> 
> But then I noticed that other rmmod implementations allow you to pass a
> list of modules, not just one (whereas we were ignoring all but the
> first). And that the help syntax was wrong. And that strend() lets us
> write the code to remove the ".ko" suffix a bit nicer.

Applied.

Modules are one of the things I need the mkroot+qemu test system to regression
test. (I'm actually reasonably close to getting that test setup working. The
blocker's been the shell, and toysh can run some reasonable scripts now...)

Rob



More information about the Toybox mailing list