[Toybox] [PATCH] pmap: cleanup.

enh enh at google.com
Mon Sep 27 10:23:32 PDT 2021


yeah, it was actually the ownership of the line allocations that was most
difficult for me to convince myself was correct here (which is why far more
effort went into rewriting that than the one-line sscanf).

i'm in the "just use cat" club too, but this was another thing that upsets
the static analyzer that's easy to just think about once and not worry
about again...

On Sun, Sep 26, 2021 at 1:03 PM Rob Landley <rob at landley.net> wrote:

> On 9/25/21 8:44 PM, enh via Toybox wrote:
> > Remove unbounded scanfs.
>
> *shrug* I tend to trust data that comes from the kernel via a mount point
> put
> there by root, but if it's bothering you...
>
> (I've never actually used pmaps, I always just look at /proc/$PID/maps or
> /proc/$PID/smaps directly...)
>
> Rob
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20210927/e0413096/attachment-0001.htm>


More information about the Toybox mailing list