[Toybox] sort tests broken?

enh enh at google.com
Wed Aug 24 17:33:09 PDT 2022


huh, so the timeout bug wasn't anything i was expecting... patch sent!

that just leaves the tar tests failing now. in the absence of any better
plan, should we just go ahead and use one of the low-numbered gids that
happens to match between Linux and macOS?

On Tue, Aug 23, 2022 at 11:29 PM Rob Landley <rob at landley.net> wrote:

>
>
> On 8/23/22 11:55, enh wrote:
> > no, and (oddly?) neither does _reverting_ that change...
> >
> > ~$ git clone https://github.com/landley/toybox.git
> > <https://github.com/landley/toybox.git> toybox
> > Cloning into 'toybox'...
> > cdremote: Enumerating objects: 26019, done.
> > remote: Counting objects: 100% (137/137), done.
> > remote: Compressing objects: 100% (62/62), done.
> > remote: Total 26019 (delta 78), reused 108 (delta 75), pack-reused 25882
> > Receiving objects: 100% (26019/26019), 11.00 MiB | 19.84 MiB/s, done.
> > Resolving deltas:  24% (4531/18878))
> > Resolving deltas: 100% (18878/18878), done.
> > m~$ cd toybox
> > ~/toybox$ make macos_defconfig
> > cc -o kconfig/conf kconfig/conf.c kconfig/zconf.tab.c -DKBUILD_NO_NLS=1 \
> > -DPROJECT_NAME=\"ToyBox\"
> > scripts/genconfig.sh
> > KCONFIG_ALLCONFIG=./kconfig/macos_miniconfig kconfig/conf -n Config.in >
> /dev/null
> > ~/toybox$ make test_sort
> > scripts/test.sh sort
> > scripts/runtest.sh: line 217: syntax error near unexpected token `;'
> > scripts/runtest.sh: line 217: `      R) LEN=0; B=1; ;&'
> > sort:Library probe
> > generated/{Config.in,newtoys.h,flags.h,globals.h,tags.h,help.h}
> > Compile generated/testdir/sort..................
> > scripts/test.sh: line 42: realpath: command not found
> > usage: dirname string [...]
> > PASS: sort unknown argument
> > PASS: sort sort
> > PASS: sort #2
> > PASS: sort stdin
> > PASS: sort numeric
> > PASS: sort reverse
> > PASS: sort sort -o
> > PASS: sort sort -o same
> > PASS: sort one key
> > PASS: sort key range with numeric option
> > PASS: sort key range with numeric option and global reverse
> > PASS: sort key range with multiple options
> > PASS: sort key doesn't strip leading blanks, disables fallback global
> sort
> > PASS: sort key edge case with -t
> > PASS: sort -k2,2f
> > PASS: sort -k2,2
> > PASS: sort -f -k2,2
> > PASS: sort -t, -k3n
> > scripts/runtest.sh: eval: line 150: syntax error near unexpected token
> `&'
> > scripts/runtest.sh: eval: line 150: `"/sort" -c |& grep -o [0-9]*'
>
> Sigh: |& is a bashism.
>
> I _really_ need to get toysh to the point it runs the test suite. Lemme
> finish
> diff and the relative path thing first...
>
> Rob
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20220824/6889cf0d/attachment.htm>


More information about the Toybox mailing list