[Toybox] [PATCH] tests.tar: fix tests for macOS.

enh enh at google.com
Mon Aug 29 17:22:46 PDT 2022


ping? i saw you added another tar test, but let me know your thoughts on
this before i rebase and fix the new test...

On Fri, Aug 26, 2022 at 4:29 PM enh <enh at google.com> wrote:

> macOS doesn't have a 'root' group (it uses 'wheel' instead), which
> we can work around by using 'sys', since that happens to have the
> same gid on Linux and BSD. (Android doesn't have a 'sys' group, but
> I can fix that and give it the same number myself -- we already
> have similar hacks for Linux Test Project tests -- and this seems
> like the only way out of our current situation that doesn't require
> abandoning the "sha" style of test we have here.)
>
> macOS uses a different device for /dev/null, so work around that too.
>
> I don't have a good workaround for macOS' weird sparse file behavior
> (not least because I still haven't understood what it does/doesn't
> support), so I've just disabled all sparse tests for now.
>
> I fixed some of the symlink tests (where macOS has group r-x and
> Linux group rwx) where we're just doing text comparisons, but I've
> just skipped the "sha" style tests that use symlinks for now.
>
> With this change, there are no test failures for me on macOS 12.5
> or on current-ish debian.
> ---
>  tests/tar.test | 101 ++++++++++++++++++++++++++++---------------------
>  1 file changed, 58 insertions(+), 43 deletions(-)
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20220829/317a8d87/attachment.htm>


More information about the Toybox mailing list