[Toybox] [PATCH] in seq.c rename itoa to toybox_itoa, to avoid clashes

John profiterolltv at protonmail.com
Sat Feb 19 07:07:54 PST 2022


> > what was the actual issue you were seeing?

I know on your website you say (quite rightly) "I don't do windows" but compiling with Cygwin on Fedora, seq.c produces the following error:

toys/lsb/seq.c:57:14: error: conflicting types for 'itoa'; have 'char *(char *, int)'
   57 | static char *itoa(char *s, int i)
      |              ^~~~
In file included from ./toys.h:31,
                 from toys/lsb/seq.c:26:
/usr/x86_64-pc-cygwin/sys-root/usr/include/stdlib.h:227:9: note: previous declaration of 'itoa' with type 'char *(int,  char *, int)'
  227 | char *  itoa (int, char *, int);
      |         ^~~~
make: *** [.singlemake:212: seq] Error 1

Perhaps this is an issue only with this particular toolchain, for now I am okay with patching the file if it doesn't seem worth changing.

-John



More information about the Toybox mailing list