[Toybox] [PATCH] timeout.test: fix test for systems that don't have bash.

enh enh at google.com
Mon Jul 25 08:23:35 PDT 2022


looks like e5ten suggests s/SIGTERM/TERM/ to fix this for all shells on
https://github.com/landley/toybox/commit/a41bbf8eec0c09470c2d5aa78f451d02b8ea99c3#commitcomment-79307732
?

On Sat, Jul 23, 2022 at 9:05 PM Rob Landley <rob at landley.net> wrote:

> On 7/21/22 12:05, enh wrote:
> > Ping?
> >
> > On Wed, Jul 20, 2022, 16:50 enh <enh at google.com <mailto:enh at google.com>>
> wrote:
> >
> >     (Such as Android.)
> >     ---
> >      tests/timeout.test | 2 +-
> >      1 file changed, 1 insertion(+), 1 deletion(-)
>
> With /bin/sh pointing to Debian's Defective Annoying SHell:
>
> trap: SIGTERM: bad trap
> PASS: timeout trap-and-exit
> trap: SIGTERM: bad trap
>
> Which is why I had it say bash instead of dash. (And just wasted time
> debugging
> it again because I'd forgotten and thought my recent lib/args.c changes
> broke
> it...) Basically, while dash continues to exist #!/bin/sh is broken and
> useless.
>
> Rob
>
> P.S. I'm now at five bounce messages from Dreamhost, and need to resend
> all that
> if they can get the list back up eventually...
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20220725/a71a43a9/attachment.htm>


More information about the Toybox mailing list