[Toybox] [PATCH] killall: fix a logic error in names_to_pid().

Rob Landley rob at landley.net
Tue Jul 26 23:01:21 PDT 2022


On 7/26/22 17:59, enh wrote:
> This broke a lot of tests in postsubmit, and even seems to have had the
> effect of causing reboots (presumably by accidentally killing init)
> which made it quite hard to track down.

Isn't this why init has signals blocked?

> Sadly I'm too stupid by this point in the afternoon to come up with the
> missing test :-(

Properly testing killall and rm goes under mkroot, precisely _because_ it can do
bad things to the system if it goes wrong...

Rob


More information about the Toybox mailing list