[Toybox] diff not passing tests?

[enh]

looks like this was caused
https://github.com/landley/toybox/commit/92a7778fcf1e8196304bb138b6da6e1b599e1d8a

github's CI tried to tell us when it was committed (
https://github.com/landley/toybox/runs/7486812337?check_suite_focus=true)
but because the mac tar tests were already failing, we couldn't see. oh, no
--- the ubuntu failure was from my timeout.test fix; we're not even running
the diff tests (or the skeleton tests, which is relevant in this case) in
CI.

let me know whether you want to just revert the args.c change (in which
case i'll keep trying to fix forward) or you're going to fix it (which
might take a while, so i'll revert the recent AOSP sync that's causing
problems)...

On Wed, Jul 27, 2022 at 9:05 AM enh <enh at google.com> wrote:

> trying to take the fix for killall, but it looks like diff is broken?
>
> -- diff
> /system/bin/sh: /data/local/tmp/toybox-tests/runtest.sh[231]: syntax
> error: unexpected operator/operand '=~'
> PASS: diff unknown argument
> PASS: diff missing
> PASS: diff - -
> PASS: diff simple
> PASS: diff -r
> PASS: diff --strip-trailing-cr off
> PASS: diff --strip-trailing-cr on
> PASS: diff line format
> FAIL: diff line format empty
> echo -ne '' | "/system/bin/diff" --unchanged-line-format=
> --old-line-format=D%l --new-line-format=A%l aa bb
> --- expected 2022-07-27 15:42:10.739996975 +0000
> +++ actual 2022-07-27 15:42:10.763996975 +0000
> @@ -1 +1,2 @@
> -D2A3
> \ No newline at end of file
> +--old-line-format=D12
> +A3
> \ No newline at end of file
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20220727/c90b4bc2/attachment.htm>