[Toybox] [PATCH] Enlarge macos_defconfig.

enh enh at google.com
Mon Jun 20 19:31:05 PDT 2022


On Mon, Jun 20, 2022 at 3:24 PM Rob Landley <rob at landley.net> wrote:

> On 6/19/22 13:19, enh via Toybox wrote:
> > On Sun, Jun 19, 2022 at 11:02 AM enh <enh at google.com <mailto:
> enh at google.com>> wrote:
> >
> > Add everything that uses xgetrandom(), and also everything that has
> > tests (but isn't still in pending) to the macos_defconfig.
> >
> > I've sorted the list because it's impossible to manage otherwise.
> >
> > All of the tests pass, except for the tar tests that were already
> > failing because there's no *group* called "root" on macOS (group 0
> > is called "wheel" instead). I haven't fixed that because it's quite
> > invasive, and TIL we're already ignoring macOS test failures in the
> > github CI (which is why we hadn't noticed this). There's also one
> > failure in the truncate tests: macOS doesn't do sparse file extension.
> >
> > actually, that's incorrect --- it does (on some/most file systems), but
> the
> > problem with the test is that we use `stat -c`. unfortunately the macOS
> stat(1)
> > only understands `-f` (which means something different to toybox). it
> doesn't
> > understand `-c` or `--format`. this is quite a widespread problem
> through the
> > tests though, not just that one test.
>
> In theory if it's the full "make tests" it should be using toybox stat
> to run the other tests. In practice, if stat isn't building on
> macos...
>

ah, good point... i've poked a bit more and will send a patch.


> Rob
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20220620/454e57c1/attachment-0001.htm>


More information about the Toybox mailing list