[Toybox] [PATCH] readelf: fix an off-by-one and a missing newline.

Rob Landley rob at landley.net
Mon Apr 24 05:11:05 PDT 2023


On 4/21/23 20:59, Rob Landley wrote:
> On 4/21/23 15:02, enh via Toybox wrote:
>> Bug: https://github.com/android/ndk/issues/1866
>> <https://github.com/android/ndk/issues/1866>
>> ---
>>  toys/other/readelf.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> If offset == size you're one past the end of the file?
> 
> What's the bug slash use case here?

For reference, I read the thread and downloaded the libbz2.so they referenced
and ran readelf -a on it, and didn't see an error message?

(Happy to apply the fix, but I still don't quite understand the issue, and kinda
want to reproduce it and add a test...)

> Rob

Rob


More information about the Toybox mailing list