[Toybox] macOS realpath test failures

[enh]

and here's the ls -lR for it...

~/aosp-master-with-phones/external/toybox$ ./run-tests-on-android.sh
realpath
tests/: 226 files pushed, 0 skipped. 0.4 MB/s (720526 bytes in 1.768s)
scripts/runtest.sh: 1 file pushed, 0 s...pped. 53.1 MB/s (6754 bytes in
0.000s)

-- realpath
PASS: realpath realpath .
PASS: realpath missing
PASS: realpath missing2
PASS: realpath -z
PASS: realpath file
PASS: realpath dir
PASS: realpath --relative-to
PASS: realpath --relative-to2
PASS: realpath --relative-to3
PASS: realpath --relative-to4
PASS: realpath --relative-base
PASS: realpath --relative-base stomps --relative-to
PASS: realpath -m with relative-base1
PASS: realpath -m with relative-base2
PASS: realpath -m with relative-base3
PASS: realpath missing defaults to -m
PASS: realpath missing -e
PASS: realpath -L
PASS: realpath -s
PASS: realpath -s link/..
PASS: realpath -s .. eats symlink
FAIL: realpath -s .. eats symlink in $PWD
echo -ne '' | cd dos && realpath -s ..
--- expected 2023-01-09 21:52:49.611701819 +0000
+++ actual 2023-01-09 21:52:49.635701818 +0000
@@ -1 +1 @@
-/data/local/tmp/toybox-tests-tmp.a8tofxJqRN/realpath
+/data/local/tmp/toybox-tests-tmp.a8tofxJqRN/realpath/one

_________________________________________________________________________

PASSED: 0
FAILED: realpath
~/aosp-master-with-phones/external/toybox$ adb shell ls -lR
/data/local/tmp/toybox-tests-tmp.a8tofxJqRN/realpath
/data/local/tmp/toybox-tests-tmp.a8tofxJqRN/realpath:
total 11
-rw-rw-rw- 1 root root   57 2023-01-09 21:52 actual
lrwxrwxrwx 1 root root    7 2023-01-09 21:52 dos -> one/two
-rw-rw-rw- 1 root root   53 2023-01-09 21:52 expected
-rw-rw-rw- 1 root root    0 2023-01-09 21:52 file
drwxrwxrwx 3 root root 3452 2023-01-09 21:52 one
lrwxrwxrwx 1 root root    5 2023-01-09 21:52 uno -> ./one

/data/local/tmp/toybox-tests-tmp.a8tofxJqRN/realpath/one:
total 3
drwxrwxrwx 3 root root 3452 2023-01-09 21:52 two

/data/local/tmp/toybox-tests-tmp.a8tofxJqRN/realpath/one/two:
total 3
drwxrwxrwx 2 root root 3452 2023-01-09 21:52 three

/data/local/tmp/toybox-tests-tmp.a8tofxJqRN/realpath/one/two/three:
total 0
~/aosp-master-with-phones/external/toybox$

On Thu, Jan 5, 2023 at 5:36 PM enh <enh at google.com> wrote:

>
>
> On Fri, Dec 16, 2022 at 6:42 PM Rob Landley <rob at landley.net> wrote:
>
>> On 12/16/22 13:10, enh wrote:
>> > looks like there's a realpath failure (but no change to any of the
>> other tests):
>> >
>> > -- realpath
>> > PASS: realpath -s link/..
>> > PASS: realpath -s .. eats symlink
>> > FAIL: realpath -s .. eats symlink in $PWD
>> > echo -ne '' | cd dos && realpath -s ..
>> > --- expected 2022-12-16 17:30:41.167996851 +0000
>> > +++ actual 2022-12-16 17:30:41.179996850 +0000
>> > @@ -1 +1 @@
>> > -/data/local/tmp/toybox-tests-tmp.gAHArSomwm/realpath
>> > +/data/local/tmp/toybox-tests-tmp.gAHArSomwm/realpath/one
>>
>> Hmmm...
>>
>> PASS: realpath -s .. eats symlink
>> PASS: realpath -s .. eats symlink in $PWD
>> PASS: realpath -es dangling symlink
>>
>> Statically built with android-ndk-r25b it's passing for me? What
>> filesystem are
>> you using?
>>
>
> looks like f2fs... (patch for portability.c so `stat -f` decodes that
> sent!)
>
>
>> Rob
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20230109/2f689b56/attachment.htm>