[Toybox] [PATCH] Try to debug modinfo test flake.

[enh]

indeed. i don't know _why_ this is happening, but i think that means the
fix (attached) is obvious at least.



On Sat, May 27, 2023 at 9:40 AM Rob Landley <rob at landley.net> wrote:

> On 5/26/23 17:57, enh via Toybox wrote:
> > We're seeing (rare) flake in CI, without enough information to even
> > guess what the problem might be:
> > ```
> > FAIL: modinfo -F filename gets absolute path
> > echo -ne '' | modinfo -F filename
> > --- expected 2023-05-09 07:43:19.487000369 +0000
> > +++ actual 2023-05-09 07:43:19.507000369 +0000
> > @@ -1 +0,0 @@
> > -
> > ```
> >
> > Maybe at least knowing the module name will help?
>
> The "echo -ne" line right after the FAIL: line shows the command line that
> got
> called (and the input sent to it, in this case none). Your change:
>
> -testing "-F filename gets absolute path" "modinfo -F filename $MODULE1" \
> -  "$MODULE_PATH1\n" "" ""
> +testing "-F filename $MODULE1 gets absolute path" \
> +  "modinfo -F filename $MODULE1" "$MODULE_PATH1\n" "" ""
>
> doesn't seem like it's providing more information? The old one had
> $MODULE1 at
> the end of the command line, but your cut and paste failure message ends
> after
> -F filename, so it looks like $MODULE1 was blank?
>
> Rob
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20230607/fe60f966/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-modinfo.test-skip-the-F-test-if-we-don-t-have-a-modu.patch
Type: text/x-patch
Size: 1987 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20230607/fe60f966/attachment.bin>