[Toybox] [PATCH] Try to debug modinfo test flake.

[enh]

On Wed, Jun 7, 2023 at 5:28 PM Rob Landley <rob at landley.net> wrote:

> On 6/7/23 14:40, enh wrote:
> > indeed. i don't know _why_ this is happening,
>
> Race condition setting up the VM? Permissions hiccup? No idea, but I've
> been
> rereading the Discworld "watch" books recently and... let's just say by
> halfway
> through Jingo prolonged exposure to Sam Vimes is not making me LESS
> inclined to
> track things down. :P
>
> In the "I break everything" department: your description has a patch in
> it, so
> "git am" on the attached file is barfing because the file "actual" is not
> in the
> repo. (I would have assumed git format-patch had an existing escape syntax
> for
> the in-band signalling the way "From:" lines in mbox files do, but
> apparently not?)
>
> > but i think that means the fix (attached) is obvious at least.
>
> Your sort returns modules from the newest kernel installed, but I let
> apt-get
> upgrade install new kernels regularly-ish, but sometimes don't reboot my
> laptop
> for months at a time, so the newest kernel installed in the filesystem and
> the
> one I'm running aren't necessarily the same thing. (And sort isn't version
> sort...) Also, in _theory_ you could have one module each installed from
> two
> kernel versions (but a _different_ single module installed from each
> kernel) and
> then the two modules test would fail...
>
> Instead I'm adding $(uname -r) to $MODULE_ROOT in the non-android case to
> avoid
> duplicates, and...


good point. (i get forcibly rebooted rather regularly by security policy,
so i'm rarely in this situation.)


> why are we discarding stderr on the calls to head and tail?
> (It's not going to discard it from find, it's in the wrong place in the
> pipeline
> for that...)
>
> I also added comments about why we DON'T have to quote stuff, because it
> was
> either that or add the quotes to get my shoulders to relax...
>
> Try commit a5b5749cc7f0
>

that actually seems to have _broken_ things more reliably? looking at your
change, it seems like you forgot to actually touch the -F test?

-- modinfo
basename: Needs 1 argument (see "basename --help")
basename: Needs 1 argument (see "basename --help")
basename: Needs 1 argument (see "basename --help")
basename: Needs 1 argument (see "basename --help")
PASS: modinfo missing
modinfo: Needs 1 argument (see "modinfo --help")
PASS: modinfo treats - and _ as equivalent
modinfo: Needs 1 argument (see "modinfo --help")
PASS: modinfo treats _ and - as equivalent
modinfo: Needs 1 argument (see "modinfo --help")
FAIL: modinfo -F filename gets absolute path
echo -ne '' | modinfo -F filename
--- expected 2023-06-08 17:21:10.863977489 +0000
+++ actual 2023-06-08 17:21:10.871977488 +0000
@@ -1 +0,0 @@
-



> Rob
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20230608/e772e9b4/attachment.htm>