[Toybox] [PATCH] Try to debug modinfo test flake.

Rob Landley rob at landley.net
Sat May 27 09:40:12 PDT 2023


On 5/26/23 17:57, enh via Toybox wrote:
> We're seeing (rare) flake in CI, without enough information to even
> guess what the problem might be:
> ```
> FAIL: modinfo -F filename gets absolute path
> echo -ne '' | modinfo -F filename
> --- expected 2023-05-09 07:43:19.487000369 +0000
> +++ actual 2023-05-09 07:43:19.507000369 +0000
> @@ -1 +0,0 @@
> -
> ```
> 
> Maybe at least knowing the module name will help?

The "echo -ne" line right after the FAIL: line shows the command line that got
called (and the input sent to it, in this case none). Your change:

-testing "-F filename gets absolute path" "modinfo -F filename $MODULE1" \
-  "$MODULE_PATH1\n" "" ""
+testing "-F filename $MODULE1 gets absolute path" \
+  "modinfo -F filename $MODULE1" "$MODULE_PATH1\n" "" ""

doesn't seem like it's providing more information? The old one had $MODULE1 at
the end of the command line, but your cut and paste failure message ends after
-F filename, so it looks like $MODULE1 was blank?

Rob


More information about the Toybox mailing list