[Toybox] [PATCH] microcom: move from e[x]it to [q]uit.

[Rob Landley]

On 11/2/23 16:56, enh via Toybox wrote:
> This frees up 'x' for xmodem transfers later.

Q to quit makes sense, adding xmodem... do you have an xmodem protocol extension
in mind that doesn't pad the last packet up to 128 bytes? What xmodem command
are you going to run at the other end to consume the data and send the replies,
and how will the terminal program know to run it?

I still lean towards running a child command here. Heck, _vi_ has that (for some
reason), I know because I keep hitting it accidentally. Whether we then add a
zmodem command to toybox is a separate question...

> Also, if we're going to have a single line of help, switch to the more
> common format for such prompts

More common where? All the hits for grep '"[^"]*[[].[]][^"]*"' toys/*/*.c
lib/*.c main.c are false positives finding array access between two strings. I
don't think I've seen toybox use this anywhere else?

Then again, grep '"[^"]* .)[^"]*"' toys/*/*.c lib/*.c main.c  isn't finding any
other non-false-positive hits. If you have a strong opinion about this, I can
switch, but I just want to be clear that either way this seems to be introducing
a new rule into the project, and you want that rule to be [a] command rather
than a) command.

> (and, if nothing else, fix the previously
> inconsistent spacing between options

Yup, my bad. :)

> and make it clear what new options
> should look like).

I'd rather not apply the patch as is because of the above commit comment
grumbles, but don't object to code change itself. Should I switch the -64 to &31
while I'm there?

Rob

P.S. Oh goddess, I just "grep -ir modem busybox/" and yes busybox has an "rx"
command. But it doesn't have a corresponding sx command, which makes every
little sense? Who sends it files?

https://unix.stackexchange.com/questions/186706/what-is-the-complementary-command-to-rx-for-xmodem-transfer