[Toybox] [PATCH] vi.c: added v command, updated help text, Fixed memory leak in 'g' command

[Rob Landley]

On 10/14/23 17:15, Oliver Webb via Toybox wrote:
> I have added the 'v' command (Which is essentially the opposite of the g[lobal] command).
> Fixed a memory leak in the g[lobal] command (Freeing data while aborting)
> Along with some code formatting (Replacing *(cmd+1) with cmd[1])

I removed the hunk adding a SUBSTRING() macro which you never called and which
doesn't seem that much of an improvement over the call to xmprintf() anyway...

By the way, I've mostly been cleaning up the:

.git/rebase-apply/patch:56: trailing whitespace.    }
warning: 1 line adds whitespace errors.

in all your patches, but I didn't bother this time.

> I have been trying to get a implementation of the s[ubsitute] command to work in vi.c.
> The best I have been able to implement barely works. I know sed.c has one that does what
> I am trying to do but I haven't been able to implement the algorithm that sed.c is using.

I was hoping to get stuff to share code, but I can worry about that in the
eventual cleanup pass.

Rob