[Toybox] [PATCH] timeout.test: reduce flake.

enh enh at google.com
Mon Apr 8 13:28:18 PDT 2024


A (presumably overloaded) CI server saw the `exit 0` test time out.
Given that several of these tests should just fail immediately,
having a huge timeout isn't even a bad thing --- if we had a bug
that caused us to report the correct status, but not until the
timeout had _also_ expired, this would make that failure glaringly
obvious.

Aren't the other tests with 0.1s timeouts potentially flaky? Yes,
obviously, but I'll worry about those if/when we see them in real
life? (Because increasing those timeouts _would_ increase overall
test time.)
---
 tests/timeout.test | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-timeout.test-reduce-flake.patch
Type: application/octet-stream
Size: 2093 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20240408/4d581e14/attachment.obj>


More information about the Toybox mailing list