[Toybox] utf8towc(), stop being defective on null bytes ([PATCH])

Oliver Webb aquahobbyist at proton.me
Mon Apr 8 16:45:14 PDT 2024


On Monday, April 8th, 2024 at 12:22, Oliver Webb via Toybox <toybox at lists.landley.net> wrote:
> On Mon, Apr 8, 2024 at 12:00, Rob Landley <rob at landley.net> wrote:
> 
> > On 4/8/24 11:53, Oliver Webb wrote:
> > > Still, U+0000 is a valid code point, and having a special case especially for it
> > > that isn’t mentioned but you have to watch out for is either a bug or a
> > > documentation error.
> > 
> > I say it's intentional, you reassert that I'm wrong.
> 
> this is at least the 4th time I said “if you want that behavior, that’s fine… but can we at least document the Landmine so no one steps on it”
> 
>
Since apparently this isn't a bug, can we at least update the comment to match the code.
(This is the solution I was implying when I said "or a documentation error", and "A special case
for null bytes is fine, but to save me and any other person that debugging nightmare when they
try to do utf8 processing on data with null bytes in it. I'd prefer if that was mentioned somewhere."
in the email you didn't read ("What's context needed for?"))

Attached...

-   Oliver Webb <aquahobbyist at proton.me>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Update-comment-in-utf8towc-to-match-what-code-is-doi.patch
Type: text/x-patch
Size: 780 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20240408/57113777/attachment.bin>


More information about the Toybox mailing list