[Toybox] [PATCH] tar.test: don't test non-`-p` behavior as root.

[enh]

On Thu, Aug 1, 2024 at 1:06 AM Rob Landley <rob at landley.net> wrote:
>
> On 7/29/24 16:27, enh wrote:
> > On Sat, Jul 27, 2024 at 3:51 PM Rob Landley <rob at landley.net> wrote:
> >> On 7/23/24 14:55, enh via Toybox wrote:
> >> > Fixes https://github.com/landley/toybox/issues/512.
> >>
> >> Applied, but could you email me the tarball for the tar "ownership" test that
> >> produces the 2d7b hash? I'm getting a d9e7 hash here, and just confirmed the
> >> previous laptop doing TEST_HOST with devuan brochitis was also producing
> >> d9e7. (Which I didn't notice because passing all root tests is under the
> >> mkroot todo item...)
> >
> > i'm not sure what you're talking about? this isn't a hash-related test?
> >
> > FAIL: tar honor umask
> > echo -ne '' | umask 0022 && rm -rf dir && mkdir dir && tar xf
> > $FILES/tar/dir.tar && stat -c%A dir dir/file
> > --- expected 2024-07-29 21:26:48.484171554 +0000
> > +++ actual 2024-07-29 21:26:48.668171554 +0000
> > @@ -1,2 +1,2 @@
> > -drwxr-xr-x
> > --rwxr-xr-x
> > +drwxrwxrwx
> > +-rwxrwxrwx
>
> The tar "ownership" test.
>
> FAIL: tar ownership
> echo -ne '' | tar c --owner root --group sys --mtime @1234567890 dir/file | SUM 3
> --- expected    2024-07-27 20:00:52.967977767 +0000
> +++ actual      2024-07-27 20:00:52.971977767 +0000
> @@ -1 +1 @@
> -2d7b96c7025987215f5a41f10eaa84311160afdb
> +d9e7fb3884430d29e7eed0dc04a2593dd260df14
>
> I applied the patch you sent, but checking the other root-only tests I'm getting
> a different test failing, and I'm not sure it ever worked for me.

yes, on Android (as root, the only way we test) only two tests are skipped:

SKIP: tar ownership
SKIP: tar honor umask

the reason for the former (as hinted at by the `skipnot chown
nobody:nogroup dir/file 2>/dev/null`) is that there is no "nogroup" on
Android.

an alternative here would be to use nobody:nobody, which works on all
of Android/Debian/macOS. i don't know if we considered that at the
time? it sounds familiar now i'm typing it out...

> Rob