[Toybox] [PATCH] devmem: add --no-sync option.

enh enh at google.com
Thu Aug 1 09:29:22 PDT 2024


Although O_SYNC is what you want 99% of the time, there is also a use
for not supplying the flag. See drivers/char/mem.c's uncached_access().

The big question here is probably the bikeshed issue of whether to name
the option after what it does (disable the O_SYNC flag) or _why_ you're
doing that. I opted for the former on the basis of "given the -f
argument, you're not necessarily talking to the /dev/mem driver, and
other drivers might use this for other things", even though I'm not
aware of any such driver personally. (Also, it's the shorter name!)
---
 toys/other/devmem.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-devmem-add-no-sync-option.patch
Type: text/x-patch
Size: 2615 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20240801/66bdb666/attachment-0001.bin>


More information about the Toybox mailing list