[Toybox] incorrect output from grep -w --color

Peter Collingbourne pcc at google.com
Wed Jan 31 10:25:25 PST 2024


Thanks! Verified that this fixes my reduced test case as well as my
original reproducer.

Peter

On Wed, Jan 31, 2024 at 10:08 AM enh <enh at google.com> wrote:
>
> pcc: that's merged in AOSP now, so let me know if that fixes everything for you (so i can update the _host_ prebuilts before anyone hits this there).
>
> On Tue, Jan 30, 2024 at 2:57 PM Rob Landley <rob at landley.net> wrote:
>>
>> On 1/22/24 21:09, Rob Landley wrote:
>> > On 1/17/24 18:57, Rob Landley wrote:
>> >> On 1/17/24 15:16, Peter Collingbourne via Toybox wrote:
>> >> Thanks. Digging into it...
>> >
>> > Looks like I screwed up --color when adding the bucket sort logic. (I haven't
>> > got regression tests for --color, because unless I'm exactly matching the ascii
>> > escape sequences I'd just be filtering them out in the test...)
>> ...
>> > So if you're wondering why that's taking so long to fix... it's because my test
>> > suite didn't have enough tests and I had work out how to add more.
>>
>> Try commit 6d9a752ac585.
>>
>> > Rob
>>
>> Rob
>> _______________________________________________
>> Toybox mailing list
>> Toybox at lists.landley.net
>> http://lists.landley.net/listinfo.cgi/toybox-landley.net


More information about the Toybox mailing list