[Toybox] toybox tar test failure

[enh]

On Wed, Jul 17, 2024 at 3:07 AM Rob Landley <rob at landley.net> wrote:
>
> On 7/15/24 12:11, enh via Toybox wrote:
> > tried to sync this morning, but i'm getting a new tar test failure:
>
> Saw this yesterday but didn't have the email laptop with me. (I need to move
> that over...)
>
> > FAIL: tar honor umask
> > echo -ne '' | umask 0022 && rm -rf dir && mkdir dir && tar xf
> > $FILES/tar/dir.tar && stat -c%A dir dir/file
> > --- expected 2024-07-15 16:20:47.217287424 +0000
> > +++ actual 2024-07-15 16:20:47.257287423 +0000
> > @@ -1,2 +1,2 @@
> > -drwxr-xr-x
> > --rwxr-xr-x
> > +drwxrwxrwx
> > +-rwxrwxrwx
>
> I can't reproduce it. I just did a fresh clone on the old machine and "make
> clean defconfig tests" completed, including running the new tar tests.
>
> The _symptom_ is that it ran the new tests against old toybox tar from before
> commit 93718452b9f6. That's the behavior from before the fix. Is your test setup
> calling an older toybox tar out of the host $PATH maybe?

no, this was on a device, so it'll be the /system/bin/toybox from the build.

> > also (since possibly WAI, and not a blocker because we ignore toybox
> > failures in tests if we're not using the toybox implementation), one
> > of the awk tests fails against Android's "one true awk":
>
> Ray replied to that, I haven't opened the can of worms of awk cleanup yet (wanna
> cut a release with it in pending first) so I'll happily apply a fix from him if
> he posts one and otherwise punt for now...

yeah, that seems to be a mksh compatibility issue.

> Rob
> _______________________________________________
> Toybox mailing list
> Toybox at lists.landley.net
> http://lists.landley.net/listinfo.cgi/toybox-landley.net