[Toybox] [PATCH] tar.test: don't test non-`-p` behavior as root.

enh enh at google.com
Mon Jul 29 14:27:47 PDT 2024


i'm not sure what you're talking about? this isn't a hash-related test?

FAIL: tar honor umask
echo -ne '' | umask 0022 && rm -rf dir && mkdir dir && tar xf
$FILES/tar/dir.tar && stat -c%A dir dir/file
--- expected 2024-07-29 21:26:48.484171554 +0000
+++ actual 2024-07-29 21:26:48.668171554 +0000
@@ -1,2 +1,2 @@
-drwxr-xr-x
--rwxr-xr-x
+drwxrwxrwx
+-rwxrwxrwx


On Sat, Jul 27, 2024 at 3:51 PM Rob Landley <rob at landley.net> wrote:
>
> On 7/23/24 14:55, enh via Toybox wrote:
> > Fixes https://github.com/landley/toybox/issues/512.
>
> Applied, but could you email me the tarball for the tar "ownership" test that
> produces the 2d7b hash? I'm getting a d9e7 hash here, and just confirmed the
> previous laptop doing TEST_HOST with devuan brochitis was also producing d9e7.
> (Which I didn't notice because passing all root tests is under the mkroot todo
> item...)
>
> The downside of testing hashes instead of hd output is when it differs and you
> can't reproduce the old one, it doesn't say why. You added this hash in commit
> 43d398ad5d7b and it's possible it never worked for me, but if --owner --group
> --mtime aren't squashing all the variables I'd like to know what still varies.
>
> Both toybox tar and host tar are producing the same output, so it's presumably a
> filesystem thing, possibly different passwd uids for "nobody"...?
>
> Thanks,
>
> Rob
> _______________________________________________
> Toybox mailing list
> Toybox at lists.landley.net
> http://lists.landley.net/listinfo.cgi/toybox-landley.net


More information about the Toybox mailing list