[Toybox] [PATCH] more.c: More stuff, down cursor key scrolls down. Also stuff about less

[Oliver Webb]

On Wednesday, March 20th, 2024 at 00:39, David Seikel <onefang_toybox at dave.isageek.net> wrote:
> On 2024-03-20 05:02:11, Oliver Webb via Toybox wrote:
> 
> > But I have to ask the question "If it's so easy, why isn't it in toybox yet?" Is it just because
> > other TODO items taking up time, or is it because it's harder to implement than it seems.

> Long ago I wrote boxes, designed to be a starting point for a generic
> editor / pager for toybox. It included very basic implementations of
> less, more, and several well known text editors, including vi. All done
> as wrappers around a common core.
> 
> Even after trimming it down to just an example shell line editor, it was
> deemed too big to read.

I hit the "discussion" about it from 2015 grepping through the list archives.
I've taken a look at it, even went so far as to dig up the git repo for it
and clone it.

The way it is supposed to be applied into toybox isn't clear, and furthermore it
relies on a old lib/ function that was removed in I think 2018?

>From my evaluation of it. It seems like abandonware, even when it was being
fought over in 2015 (The readme still says "Please do not actually include this in toybox",
full of TODO's and other stuff, I'd link Robs reply to your 2015 thread but am too tired to
dig it up)

I've thought about running it through a cleanup pass and scraping it for parts. Because
_a_ implementation is better then no implementation. I still haven't gotten it to compile of it tho
and am not that motivated to dig up a old commit and fix everything that breaks.
I remember stuff about it relying on a ton global variables too.

I'll probably finish what I started in vi.c before trying to do less. And that is if I can
implement less, I'll see if I can use the code for boxes in a modular way, in a way that's better then
codesharing from vi.c. Then again I don't know what state the boxes.c core is for portability to
other stuff. The main reason boxes wasn't merged was because it couldn't be broken down into small patches
(size was a reason but only a auxiliary one), which doesn't give me a terrible amount of hope in using it
for parts

-   Oliver Webb <aquahobbyist at proton.me>