[Toybox] [PATCH] toysh: fix -Wuse-after-free

[Rob Landley]

On 3/25/24 20:20, enh wrote:
> On Sun, Mar 24, 2024 at 12:45 AM Rob Landley <rob at landley.net> wrote:
>     On 3/22/24 10:24, enh wrote:
>     > On Thu, Mar 21, 2024 at 8:45 PM Rob Landley <rob at landley.net> wrote:
>     >> Anyway, toys/android basically meant (to me), "commands that come from
>     and are
>     >> maintained by Elliott which I can't even test because they don't apply to a
>     >> vanilla linux system that isn't running the full android environment".
>     Although
>     >> that's a personally idiosyncratic definition because I lumped selinux in with
>     >> that;
>     >
>     > (heh. you beat me to it :-) )
> 
>     If the new kconfig greyed out unavailable entries and had a status line saying
>     "depends on TOYBOX_ON_ANDROID" or similar when you cursored over a greyed out
>     entry...
> 
> ah, as the kind of lunatic who only ever edits these files by hand with vi, i'd
> actually just assumed that was kind of the whole point of the _existing_ kconfig
> stuff?

To me half the point is it's the same UI as configuring the linux kernel,
busybox, and buildroot. Meaning A) a bunch of people out there are familiar with
it already, B) presumably the worst sharp edges have been filed off over the
past 15 years.

> (to be fair,  i did launch it once, but saw it was a ridiculously deeply nested
> ui [and not expanded by default?], and thought "i don't understand the purpose
> of this", couldn't see how to search,

It literally has help text at the top of the screen.

Forward slash is search, cursor up and down, space to toggle the highlighted
thingy, enter to go into a menu, ESC to back out again, ESC from the top level
to exit (it prompts you whether or not you want to save), ESC twice from _that_
to abort the exit.

There's also a menu at the bottom, where if you cursor left and right it
highlights different things, and the ENTER will do that thing instead. (The
default is "select". I cursor right to "help" and hit enter because I never
remember that ? is the hotkey for that.)

Mostly I'm assuming "same UI as linux kernel" is like 2/3 of the userbase though.

> and immediately went back to editing by
> hand. at least that way i only need to know how to use my editor, which i need
> to know regardless :-) )

Dependency resolution comes to mind.
>     If we really wanted to rush this, I could make a TOYBOX_UNFINISHED symbol that
>     the pending stuff could depend on, and then the blocker is the kconfig
>     replacement...
> 
> no, i've been cursing the broken tab-complete for -- wow, almost a decade now!
> -- so i think i can survive :-)

I admit I sometimes do "ls toys/*/skel* when I can't remember whether I called
it "example" or "examples".

>     Not THIS release though. Working on release notes! (And lowering my standards on
>     the todo list.)
> 
> indeed... something that benefits the handful of folks working on toybox isn't
> worth much compared to something that benefits the users!

Working on it...

Rob