[Toybox] [PATCH] awk -- more patches

Rob Landley rob at landley.net
Wed Oct 23 10:24:28 PDT 2024


On 10/18/24 18:09, Ray Gardner wrote:
> The attached patches (tested with git am) bring toybox awk up to date.
> The first two are the same ones I sent last time I sent patches (Sep
> 7) because those have not been applied.

Lost in the noise, apparently. No obvious objections.

> I hope these can be applied
> before the next toybox release.

I applied the first 5 of this list, 6 is the compiler being stupid and 
I'd prefer to find a --fshut-up flag to make it stop. (I do 
"string"+offset in many places, and don't intend to stop. Dereference 
and then take the address of to humor compiler warnings is just silly.)

7 starts with a comment change that seemed at first glance like part of 
6, thought I'd ask.

My local llvm builds look like:

../llwrap make clean defconfig awk

(Which is warning about the extra parentheses on line 994 but not 
anything else for me.)

My llwrap script is:

CROSS_COMPILE=~/llvm/llvm- LDFLAGS+=" --static" CFLAGS+=" 
-Werror=format-security -Werror=unused-result" "$@"

With the llvm directory being a symlink to 
android-ndk-r26d/toolchains/llvm/prebuilt/linux-x86_64/bin where I have 
added an "llvm-cc" file containing:

#!/bin/bash

"$(dirname "$0")"/clang ${LLTARGET:---target=x86_64-linux-android34} "$@"

(Sigh, I need to reinstall the thunderbird extension that lets me 
disable wordwrap but they break compatability with old plugins on 
tuesdays...)

Anyway, I'm not seeing that warning on android-ndk-r26d's llvm, do I 
need a newer one...? (I can apply just the parentheses removal but I 
didn't want to edit hunks out of your patch without asking.)

Rob


More information about the Toybox mailing list