[Toybox] [PATCH] cp: fix -i and -v messages.

Rob Landley rob at landley.net
Thu Sep 12 20:50:14 PDT 2024


On 9/10/24 17:16, enh via Toybox wrote:
> cp -i was showing the _source_ rather than the destination, while -v
> was only showing the source rather than the source _and_ the destination.

In theory flags is separate because it gets locally modified, but at this point
it's only doing that for FLAG_r so you're right all the other tests can just use
the FLAG() macros. In fact having a separate extra r flag is probably the
correct thing to do here. (I think there were more local flag modifications
before, but they got cleaned up at some point...)

Applied, I'll try to do a follow-up patch this evening...

Rob


More information about the Toybox mailing list