[Toybox] clang build still broken

enh enh at google.com
Mon Jun 30 12:46:13 PDT 2025


sending as a separate thread, so it's obvious that there's new
information here... in particular, note that clang isn't complaining
about _attribute_ ordering, it's complaining that the _definition_ it
already saw doesn't match the redeclaration:

external/toybox/lib/hash.c:309:16: error: attribute declaration must
precede definition [-Werror,-Wignored-attributes]
  309 | __attribute__((__weak__)) void hash_by_name(int fd, char
*name, char *result)
      |                ^
external/toybox/lib/hash.c:22:6: note: previous definition is here
   22 | void hash_by_name(int fd, char *name, char *result)
      |      ^
external/toybox/lib/hash.c:309:32: error: redefinition of 'hash_by_name'
  309 | __attribute__((__weak__)) void hash_by_name(int fd, char
*name, char *result)
      |                                ^
external/toybox/lib/hash.c:22:6: note: previous definition is here
   22 | void hash_by_name(int fd, char *name, char *result)
      |      ^
2 errors generated.


More information about the Toybox mailing list