<div dir="auto">Did you see my alternative patch, either on the internal bug or this mailing list?<div dir="auto"><br></div><div dir="auto">I don't think we actually want to return errno...</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Aug 2, 2018, 14:01 xiewen <<a href="mailto:xiewen202@163.com">xiewen202@163.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial"><div>hi Guys:</div><div><br></div><div> I find a bug in modprobe.c:</div><div> In the following case, modprobe will fail:</div><div> First ins_mod a.ko, then ins_mod b.ko, b.ko depends on a.ko,b.ko will insmod failed.</div><div> Because syscall will return to EPERM, but finit_module and init_module actually return EEXIST,</div><div> and EEXIST is stored in errno.</div><div><br></div><div> Finally, I found that rm_mod uses errno as the return value, so I think ins_mod should also use errno as the return value.</div><div><br></div><div style="zoom:1">--<br><p><span style="FONT-FAMILY:Microsoft Yahei"><span><span><span>------------------------------------</span></span></span></span><span style="FONT-FAMILY:Georgia"><span><span></span></span></span></p><span style="FONT-FAMILY:Comic Sans MS"><span><span><span>
<p><span><span><span><span style="FONT-FAMILY:Comic Sans MS;COLOR:#000000">thanks with best regards!</span></span></span></span></p></span></span></span>
<p><span style="FONT-FAMILY:Comic Sans MS"></span><span style="FONT-FAMILY:Comic Sans MS"></span><span><span style="FONT-FAMILY:Comic Sans MS">email:</span><a style="FONT-FAMILY:Comic Sans MS" href="mailto:wen.xie@archermind.com;xiewen202@163.com" target="_blank" rel="noreferrer">wen.xie@archermind.com;xiewen202@163.com</a></span></p><span><span>
<p style="FONT-FAMILY:Comic Sans MS">phone:15850502564</p></span></span></span><span style="FONT-FAMILY:Georgia"><span></span></span><span style="FONT-FAMILY:Arial"></span>
<p> </p><div style="clear:both"></div></div></div><br><br><span title="neteasefooter"><p> </p></span>_______________________________________________<br>
Toybox mailing list<br>
<a href="mailto:Toybox@lists.landley.net" target="_blank" rel="noreferrer">Toybox@lists.landley.net</a><br>
<a href="http://lists.landley.net/listinfo.cgi/toybox-landley.net" rel="noreferrer noreferrer" target="_blank">http://lists.landley.net/listinfo.cgi/toybox-landley.net</a><br>
</blockquote></div>