<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Test 1: Agreed (thanks for pointing out i missed it) i'll remove it.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Test 2: IMO as adding d breaks the spec by not outputting the new line after space, gnu is wrong here.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Test 3: then why not stat the files or check by any other way that they are only regular files? IMO this should be a normal case that it makes width match so new line is due.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Haroon<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Samuel Holland <samuel@sholland.org><br>
<b>Sent:</b> Wednesday, August 29, 2018 11:49 PM<br>
<b>To:</b> haroon maqsood; toybox@lists.landley.net<br>
<b>Subject:</b> Re: [Toybox] [PENDING] [fold.c] [Question]</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On 08/29/18 17:28, haroon maqsood wrote:<br>
> PFA a patch for unit tests i added that can maybe go in when fold moves from <br>
> pending??, the main intention is to discuss what i was unable to <br>
> communicate(limitation on my part), i added a comment too so if anyone can <br>
> cross check , that would be helpful<br>
<br>
Thanks for providing concrete examples.<br>
<br>
Test 1: Per the spec, the tab character goes up to the next tab stop. Since the<br>
next character is at column 9 (the next tab stop), the tab made the line 8<br>
characters long, which is too wide. Since the tab makes the line too wide, you<br>
must put a newline before it.<br>
<br>
Test 2: "ef d" is exactly 4 characters, so there's no need to split the line.<br>
Regardless of if you split after whitespace or in the middle of a word, the<br>
column count resets when you output a newline.<br>
<br>
Test 3 and 4 look okay.<br>
<br>
Test 5: This is the tough one, because it's outside of the spec. The input<br>
doesn't end in a newline, so it's technically not a text file. fold(1) is only<br>
specified to operate on text files. Personally, I'd say add the newline, to make<br>
the output a text file. Apparently GNU disagrees.<br>
<br>
Samuel<br>
</div>
</span></font></div>
</body>
</html>