<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 21, 2021, 18:25 Rob Landley <<a href="mailto:rob@landley.net">rob@landley.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 9/21/21 1:54 PM, Peter Collingbourne via Toybox wrote:<br>
> This matches the behavior of GNU grep.<br>
<br>
Well, _sort_ of. The test you added won't pass TEST_HOST because:<br>
<br>
$ echo hello | grep --color=always l | hd<br>
00000000 68 65 1b 5b 30 31 3b 33 31 6d 1b 5b 4b 6c 1b 5b |he.[01;31m.[Kl.[|<br>
00000010 6d 1b 5b 4b 1b 5b 30 31 3b 33 31 6d 1b 5b 4b 6c |m.[K.[01;31m.[Kl|<br>
00000020 1b 5b 6d 1b 5b 4b 6f 0a |.[m.[Ko.|<br>
<br>
Different escapes. (The behavior's probably good enough, but the test isn't.)<br>
<br>
Hmmm, I don't need to specify the zero to go back to grey, do I? </blockquote></div></div><div dir="auto"><br></div><div dir="auto">Iirc from writing a terminal emulator, for *all* escapes that take a numeric argument, missing it out is equivalent to supplying 0. But, yeah, \x1b[m for \x1b[0m is by far the most common case of that.</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The \e[K is<br>
definitely funky though, that's delete until end of line...? (Why...?)<br>
<br>
And to be honest I'm tempted to remember the current color and optimize out<br>
unnecessary color change escapes. Hmmm...<br>
<br>
Thanks for the bug fix, good catch. Lemme poke at this a bit...<br>
<br>
Rob<br>
_______________________________________________<br>
Toybox mailing list<br>
<a href="mailto:Toybox@lists.landley.net" target="_blank" rel="noreferrer">Toybox@lists.landley.net</a><br>
<a href="http://lists.landley.net/listinfo.cgi/toybox-landley.net" rel="noreferrer noreferrer" target="_blank">http://lists.landley.net/listinfo.cgi/toybox-landley.net</a><br>
</blockquote></div></div></div>