<div dir="ltr"><div>I missed this change so creating a second patch to apply after the HTTP 1.1 patch is applied.<br></div><div><br></div><div>- Eric<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 27, 2021 at 1:58 PM Eric Molitor <<a href="mailto:emolitor@molitor.org">emolitor@molitor.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Agree, that could have been better. The attached patch adds HTTP 1.1 and chunked encoding support. It also cleans up and improves the header processing and adds comments to explain the logic. This also fixes a bug in the original implementations header processing where it was assumed that the first read would contain the complete headers. <br></div><div><br></div><div>- Eric<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 27, 2021 at 4:30 AM Rob Landley <<a href="mailto:rob@landley.net" target="_blank">rob@landley.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 10/26/21 9:05 AM, Eric Molitor wrote:<br>
> Attached is an initial cleanup of wget. This addresses a number of defects with<br>
> the existing implementation and generally cleans up the code. I've squashed the<br>
> commits but can provide a more incremental set of patches if desired. I have two<br>
> more pending changes which correctly add HTTP 1.1 support, including support for<br>
> chunked encoding, as well as adding TLS support. However this was already a huge<br>
> change so working on landing this first before submitting the others changes.<br>
<br>
Applied, but I'm not sure this moves it _closer_ to getting out of pending:<br>
<br>
+#define WGET_FILENAME "Content-Disposition: attachment; filename="<br>
...<br>
+ f = wget_strncaseafter(toybuf, WGET_FILENAME, body - toybuf);<br>
<br>
What does splitting a string a hundred lines away from its only user accomplish?<br>
<br>
Rob<br>
</blockquote></div>
</blockquote></div>