<div dir="ltr">Hello Rob Landley,<div><br></div><div>The hack has not been reverted yet, but I'll do this immediately (<a href="https://android-review.git.corp.google.com/c/kernel/build/+/2525840">https://android-review.git.corp.google.com/c/kernel/build/+/2525840</a>). I'll also revert other hacks.</div><div><br></div><div>A separate issue I see with the prebuilt tar is that it doesn't seem to extract a single file prefixed with `./`. This is best illustrated with the following example (see attached repro.sh and result.txt)</div><div><br></div><div>That is, if an archive contains `./foo` as a entry, then extracting with `tar xf foo.tar.gz ./foo` doesn't seem to extract the file properly.</div><div><br></div><div>Note: The ./prebuilts/build-tools/path/linux-x86/tar is where we have a symlink to the toybox binary. The toybox binary we are on is:</div><div><a href="https://cs.android.com/android/_/android/platform/prebuilts/build-tools/+/ed9e3dea4e2a234cb4557280b7663dcbb2b5d288:linux-x86/bin/toybox;bpv=1">https://cs.android.com/android/_/android/platform/prebuilts/build-tools/+/ed9e3dea4e2a234cb4557280b7663dcbb2b5d288:linux-x86/bin/toybox;bpv=1</a><br></div><div>which is compiled from this hash:</div><div><a href="https://android.googlesource.com/platform/external/toybox/+/6b6578da250d89a0a5929d4639fd8e44303c5a3d">https://android.googlesource.com/platform/external/toybox/+/6b6578da250d89a0a5929d4639fd8e44303c5a3d</a> "Add new test for "directory exists" and make TEST_HOST less chatty."<br></div><div><br></div><div>Could you please take a look? Thanks!</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 5, 2023 at 2:33 PM enh <<a href="mailto:enh@google.com">enh@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">typing the path name into <a href="http://cs.android.com" target="_blank">cs.android.com</a> is probably your best bet. that gets me <a href="https://cs.android.com/android/kernel/superproject/+/common-android-mainline:build/kernel/kleaf/impl/image/initramfs.bzl;bpv=0" target="_blank">https://cs.android.com/android/kernel/superproject/+/common-android-mainline:build/kernel/kleaf/impl/image/initramfs.bzl;bpv=0</a> (and there's either a git blame "layer" or a little history tab you can pop up at the bottom).<div><br></div><div>coincidentally, <a href="https://android-review.googlesource.com/c/kernel/build/+/2524056" target="_blank">https://android-review.googlesource.com/c/kernel/build/+/2524056</a> is the attempt to switch back to toybox tar, which elsk@ is trying to do right now :-)<br><div><br></div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 5, 2023 at 2:20 PM Rob Landley <<a href="mailto:rob@landley.net" target="_blank">rob@landley.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I have <a href="https://android-review.googlesource.com/c/kernel/build/+/2389693" rel="noreferrer" target="_blank">https://android-review.googlesource.com/c/kernel/build/+/2389693</a> open and<br>
I think I fixed that in commit a3fc87752193 but I can't tell if the workaround<br>
ever got removed? (Or needed to be?)<br>
<br>
Clicking through to the initramfs.bzi file mentions TODO(<a href="https://buganizer.corp.google.com/243737262" target="_blank">b/243737262</a>) but I<br>
don't know how to access that...<br>
<br>
Is there something left for me to do here, or can I close the tab?<br>
<br>
Rob<br>
_______________________________________________<br>
Toybox mailing list<br>
<a href="mailto:Toybox@lists.landley.net" target="_blank">Toybox@lists.landley.net</a><br>
<a href="http://lists.landley.net/listinfo.cgi/toybox-landley.net" rel="noreferrer" target="_blank">http://lists.landley.net/listinfo.cgi/toybox-landley.net</a><br>
</blockquote></div>
</blockquote></div>