[Toybox] Fix, killall is not allowed to kill itself
Elie De Brauwer
eliedebrauwer at gmail.com
Sun Dec 23 12:45:57 PST 2012
On 12/23/2012 09:42 PM, Rob Landley wrote:
> On 12/16/2012 11:12:59 AM, Elie De Brauwer wrote:
>> All,
>>
>> In my previous patch, the pif shouldn't be stored inside the GLOBAL(), it
>> should be just a regular global variable. In attach a patch which
>> corrects this.
>
> Ok, I finally took a proper look at this, and I don't understand why
> can't we have pid_t in GLOBALS()? It's a standard type, it's not being
> used as an argument target (in which case it would have to be a long),
> the #includes in toys.h give us that type...
>
> Could you explain your reasoning? (In the meantime, I've applied your
> first patch.)
Mea culpa, I thought GLOBALS() was only meant for command line parsing,
but apparently it isn't.
gr
E.
--
Elie De Brauwer
1356295557.0
More information about the Toybox
mailing list