[Toybox] [groups] : ! More than one in group is error

[Rob Landley]

On 12/27/2012 11:06:37 AM, Felix Janda wrote:
> When trying to implement the remaining options for "pwd" I could also  
> test
> toybox's group option handling.
> 
> The option string I wanted to use is: ">0LP[!LP]"
> (It's the same for "LP[!LP]".)
> 
> With the current argparsing I get a segfault for "pwd -L -P". When  
> enabling
> TOYBOX_DEBUG it says "pwd: trailing [!LP]". On the other hand when  
> using
> Ashwini's suggestion with disabled TOYBOX_DEBUG everthing seems to  
> work,
> whereas with enabled TOYBOX_DEBUG I get the same error message as  
> before.

Ok, this I can reproduce.  Hmmm...

Ah. You're right, the test was wrong. (It got the condition right, but  
couldn't work out the correct error message due to & vs &&.)

Testing for NULL just hid the problem, it didn't fix it. I checked in a  
fix.

Thanks,

Rob
 1356655868.0