[Toybox] [PATCH] Remove unused variable in toys/id.c

Rob Landley rob at landley.net
Mon Mar 12 18:59:28 PDT 2012


On 02/27/2012 06:26 PM, Georgi Chorbadzhiyski wrote:
> The attached patch fixes compiler warning by removing an unused but set
> variable.
> 
>   toys/id.c: In function 'id_main':
>   toys/id.c:63:8: warning: variable 'gid' set but not used
> [-Wunused-but-set-variable]

Ok, this is the oldest pending patch I have from you, and the right fix
is to make the code use the actual process gid rather than the
/etc/passwd entry.  (The setgid bit or setgid() from root could change
that.)

Tightened up the code a bit while I was there.  (There's more cleanup to
do, but I can get back to that later...)

Rob



More information about the Toybox mailing list