[Toybox] [PATCH] Remove unused variable in toys/id.c

Georgi Chorbadzhiyski gf at unixsol.org
Tue Mar 13 00:39:36 PDT 2012


On 13.3.2012 г. 03:59, Rob Landley wrote:
> On 02/27/2012 06:26 PM, Georgi Chorbadzhiyski wrote:
>> The attached patch fixes compiler warning by removing an unused but set
>> variable.
>>
>>    toys/id.c: In function 'id_main':
>>    toys/id.c:63:8: warning: variable 'gid' set but not used
>> [-Wunused-but-set-variable]
>
> Ok, this is the oldest pending patch I have from you, and the right fix
> is to make the code use the actual process gid rather than the
> /etc/passwd entry.  (The setgid bit or setgid() from root could change
> that.)
>
> Tightened up the code a bit while I was there.  (There's more cleanup to
> do, but I can get back to that later...)

I send a patch that I think fixed in properly, here:
[PATCH] toys/id: Fix output formating and ask for correct group id.
Message-Id: <1331211194-16335-1-git-send-email-gf at unixsol.org>

-- 
Georgi Chorbadzhiyski
http://georgi.unixsol.org/

 1331624376.0


More information about the Toybox mailing list