[Toybox] FTP commands
ibid.ag at gmail.com
ibid.ag at gmail.com
Fri Dec 27 09:49:59 PST 2013
On Fri, Dec 27, 2013 at 08:39:42AM -0600, Rob Landley wrote:
> On 12/12/13 19:39, ibid.ag at gmail.com wrote:
> >On Thu, Dec 12, 2013 at 02:25:38PM +0530, Ashwini Sharma wrote:
> >>Hi,
> >>
> >>The input parameter port was kept as string, so that the
> >> user can also give service name like "ftp" instead of numeric PORT.
> ...
> >and initialize port to 0, if we want to keep support for -P ftp.
> >(I don't imagine anyone using -P ssh or any non-numeric port other
> >than "ftp".)
> >
> >OK, yes that works...
> >
> >Attaching my full diff, which also addresses a couple nitpicks:
>
> Um, diff relative to...? I've lost the plot.
>
Ashwini's second version; this patch replaces my first patch.
The difference is that it leaves support for non-numeric ports in place.
(It's your call if you want to use this patch or the other.)
> I applied Ashwini's second version, and your first version. Lemme
> push that, if you have further patches could you submit 'em against
> that?
Is there a call for non-numeric ports?
Thanks,
Isaac Dunham
1388166599.0
More information about the Toybox
mailing list