[Toybox] Modinfo parm/parmtype patch

Isaac idunham at lavabit.com
Mon Jul 8 19:17:10 PDT 2013


On Mon, Jul 08, 2013 at 02:59:12AM -0500, Rob Landley wrote:
> On 07/07/2013 05:57:41 PM, Andre Renaud wrote:
> >Yes, you're correct - the only way to handle that output type is to
> >buffer the parm/parmtype options until the end, and then intelligently
> >merge them. For such a minimal toy that doesn't really seem like a
> >sensible thing to do.
> >I guess the question is how close to the module-init-tools modinfo do
> >we want to be? I expect that we don't really want to be particularly
> >close if the code complexity cost is high. The simplest solution is
> >probably just to add parmtype in to the list of tags and leave it at
> >that. At least that way all the useful information is displayed so
> >people can read it.

> I'm happy to lean on other people's expertise here if you guys come
> to a consensus, but this is an area where you need to tell me what
> you need. I'm not informed enough on module usage patterns to have
> an opinion.

The patch revised as I proposed is attached.

HTH,
Isaac
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parmtype.diff
Type: text/x-diff
Size: 495 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20130708/0d3e4578/attachment-0007.diff>


More information about the Toybox mailing list