[Toybox] Fixes to mkdir, chown, env

Rob Landley rob at landley.net
Thu Sep 5 03:23:41 PDT 2013


On 08/30/2013 09:01:30 AM, Jacek Bukarewicz wrote:
> 2) env - there were 2 segfaults when run on my Ubuntu 12.04 machine:
>     - one is because eglibc sets environ to NULL on clearenv().
> I added check for environ being not NULL when iterating over  
> environment variables
>     - switched xexec to xexec_optargs because command argument is a  
> pointer to optarg which is freed by xexec.

Applied.

> 3) chown:
>     - Both ":" and "." are used as <user>:<group> delimiter but AFAIK  
> only ":" is allowed

On my ubuntu host:

$ touch walrus
$ sudo chown root.bin walrus
$ ls -l walrus
-rw-rw-r-- 1 root bin 0 Sep  5 05:16 walrus

It's not posix but busybox supports it too and it's used in the  
./configure stage of various package builds. (Do you have a specific  
reason to remove it?)

Rob
 1378376621.0


More information about the Toybox mailing list