[Toybox] [PATCH] getty should disable CLOEXEC

Isaac Dunham ibid.ag at gmail.com
Fri Aug 22 20:16:51 PDT 2014


getty needs fd 0 to stay open.
The O_CLOEXEC reversal resulted in login failing.

Thanks,
Isaac Dunham

-------------- next part --------------
diff --git a/toys/pending/getty.c b/toys/pending/getty.c
index 0cfd750..c737628 100644
--- a/toys/pending/getty.c
+++ b/toys/pending/getty.c
@@ -128,7 +128,7 @@ static void open_tty(void)
     if ((setsid() < 0) && (getpid() != getsid(0))) 
       perror_exit("setsid");
     xclose(0);
-    xopen(TT.tty_name, O_RDWR|O_NDELAY);
+    xopen(TT.tty_name, O_RDWR|O_NDELAY|O_CLOEXEC);
     fcntl(0, F_SETFL, fcntl(0, F_GETFL) & ~O_NONBLOCK); // Block read
     dup2(0, 1);
     dup2(0, 2);


More information about the Toybox mailing list