[Toybox] Simplifying (was Re: top -H segfault)

Rob Landley rob at landley.net
Thu Jun 9 13:38:07 PDT 2016



On 06/09/2016 10:16 AM, enh wrote:
> On Wed, Jun 8, 2016 at 10:25 PM, Rob Landley <rob at landley.net> wrote:
>> On 06/08/2016 09:59 PM, enh wrote:
>>> On Wed, Jun 8, 2016 at 6:37 PM, Rob Landley <rob at landley.net> wrote:
>>>>> yeah, as far as i can tell this is right.
>>>>
>>>> Ok, I'll apply it then.
>>>
>>> i can't actually tell any difference from this patch. remind me what changed?
>>
>> Processes that weren't threads had a blank TNAME (because they
>> didn't have a snapshot of their parent process's argv[0] in
>> string slot 7).
> 
> i don't see that without this patch. all three cases looked fine:
> regular java threads (process+thread, different), single-threaded
> processes like init or toybox (process), and kernel threads (thread,
> no process).

Grrr, the large uninterrupted block of time I expected is totally not
turning out like that (next week's gonna be nuts)

I'll try to get a test case to prove the patch does what I think it
does, and if not I can revert it.

> (actually, TNAME is still more useful than NAME even for init and
> toybox: it'll show "ps" rather than "toybox", for example.)

argv[0], stat[2], and exe show different things. :)

Rob



More information about the Toybox mailing list