[Toybox] Moving ps name fields around.

enh enh at google.com
Mon Jun 20 14:28:47 PDT 2016


On Mon, Jun 20, 2016 at 1:53 PM, Rob Landley <rob at landley.net> wrote:
>
>
> On 06/20/2016 11:14 AM, enh wrote:
>> On Sun, Jun 19, 2016 at 5:09 AM, Rob Landley <rob at landley.net> wrote:
>>> On 06/15/2016 12:25 PM, enh wrote:
>>>> On Tue, Jun 14, 2016 at 1:50 PM, Rob Landley <rob at landley.net> wrote:
>>>>> On 06/13/2016 07:29 PM, enh wrote:
>>>>>> AOSP is now using this, and ps lgtm.
>>>>>
>>>>> Yay!
>>>>
>>>> the netstat cleanup doesn't seem to have broken anything obvious either :-)
>>>
>>> You mean the first round of netstat cleanup didn't. :)
>>
>> okay, i'll keep an eye out :-)
>
> I checked in a second and am working on a third. I hope to get this
> promoted this week and move back to wget.

isn't dd a lot closer to being promoted than wget?

>>> I also confirmed that expanding the window width doesn't affect the
>>> ubuntu version's behavior: it's hardwired column sizes adding up to
>>> 80 columns. (Actually 79. But it was worth a look...)
>>
>> ugh. given feedback internally and from lipi lee off-list -- basically
>> everyone under the age of 65 thinks that netstat truncating addresses
>> is a bug rather than a feature and when you tell them the workaround
>> they wonder why -W isn't the default -- i was tempted to suggest we
>> make -W the default.
>
> I'm fine having -W be the default if you'd like...

i think it makes sense, though it wouldn't affect me much because the
-W habit is ingrained at this point. might help future generations
though...

>> netstat is one of those commands (like readelf) where i just
>> automatically type the -W. even when i *was* on a VT100, having
>> correct output always seemed more useful than having short output. (at
>> least GUIs that truncate tend to leave an ellipsis so you know they
>> screwed you over.)
>
> I have a todo item to make top and ps do that for the string fields, but
> haven't yet becuase there's been enough churn there recently.
>
> Anything else you wanted to add? (I noticed the busybox mailing list
> mentioning adding a few new fields, but haven't looked at the man page
> to see what they should do yet. I think two we already have?)

no, i think we already added all the ps fields Android had + anything
anyone had ever asked for. (it'll take a while for people to get used
to having -o and -O, but it's pretty convincing once they've seen it.)

> Rob



-- 
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.



More information about the Toybox mailing list