[Toybox] toybox: modprobe patch

enh enh at google.com
Thu Aug 2 14:05:10 PDT 2018


Did you see my alternative patch, either on the internal bug or this
mailing list?

I don't think we actually want to return errno...

On Thu, Aug 2, 2018, 14:01 xiewen <xiewen202 at 163.com> wrote:

> hi Guys:
>
>      I find a bug in modprobe.c:
>      In the following case, modprobe will fail:
>      First ins_mod a.ko, then ins_mod b.ko, b.ko depends on a.ko,b.ko will
> insmod failed.
>      Because syscall will return to EPERM, but finit_module and
> init_module actually return EEXIST,
>      and EEXIST is stored in errno.
>
>     Finally, I found that rm_mod uses errno as the return value, so I
> think ins_mod should also use errno as the return value.
>
> --
>
> ------------------------------------
>
> thanks with best regards!
>
> email:wen.xie at archermind.com;xiewen202 at 163.com
>
> phone:15850502564
>
>
>
>
>
> _______________________________________________
> Toybox mailing list
> Toybox at lists.landley.net
> http://lists.landley.net/listinfo.cgi/toybox-landley.net
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20180802/598caf0d/attachment.html>


More information about the Toybox mailing list