[Toybox] pcre2grep

enh enh at google.com
Thu Aug 2 15:42:10 PDT 2018

On Thu, Aug 2, 2018 at 1:56 PM Rob Landley <rob at landley.net> wrote:

> I see
> http://lists.landley.net/pipermail/toybox-landley.net/2018-August/009585.html
> but never got a copy through the list, I'm guessing gmail bounced it as
> spam.

did you see my several recent "ping" emails for other patches?

there's a modprobe patch

a wc patch:

grep tests that would have caught my PCRE mistake:

a file patch:

but you're right, here's someone else's mdev patch that i don't think i saw
on the list:

I've spent a lot of this week wrestling with the deflate code, trying to
> get it
> into lib/ and filling in the "else" case of the #ifdef zlib stuff. I was
> hoping
> to implement the missing parts of compression side (right now deflate is
> just
> doing store), but spent a lot of time just getting back up to speed and
> cleaning
> up overgrowth.
> I'm aware toybox grep needs --color, which is basically a genericization
> of the
> grep -o logic. (Instead of printing only the matches, print both match and
> non-match in different colors. Most of the plumbing's there, but built
> around
> the wrong assumption.)
> The problem with adding perl regex support to toybox grep is we use libc's
> regex. I can add a config option to pull in another library, but don't know
> what's out there for this?

well, PCRE would be the obvious choice :-) and it was tempting to me
because -- via selinux -- it's in every process on Android anyway. but -P
wasn't the goal. removing the unmaintained (by us) BSD code and switching
to some project that is maintained was my goal. and in terms of options
pcre2grep seemed closer to complete.

but, yeah, if you finish toybox grep i can contribute a PCRE -P if you want
it :-)

> Rob
> _______________________________________________
> Toybox mailing list
> Toybox at lists.landley.net
> http://lists.landley.net/listinfo.cgi/toybox-landley.net
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20180802/4acf183e/attachment.html>

More information about the Toybox mailing list